ChainMovers / suibase

Sui development environment and cookbook.
https://suibase.io
Apache License 2.0
35 stars 6 forks source link

MacOS: Failed to extract binary. Trying to re-download again #98

Closed kkomelin closed 1 month ago

kkomelin commented 1 month ago

Two users reported the same issue on MacOs after running localnet start the first time. The Github actions for MacOS failed because of the same issue Failed to extract binary. Trying to re-download again

mario4tier commented 1 month ago

Summary

Mysten Labs did not include many pre-compiled binaries in the latest 1.25 MacOS assets.

Workaround

Users can force Suibase to download/install a specific version with a change to suibase.yaml. Example to force localnet to stay on the last known version working:

force_tag: "devnet-v1.24.0"

Details

Comparison of 1.24 vs 1.25 released assets.

Screenshot from 2024-05-15 23-40-53

Suibase detects that some required binaries are missing and fails.

I will contact Mysten Labs. This might be a temporary glitch.

mario4tier commented 1 month ago

For a list of tags that can be specified in suibase.yaml: https://github.com/MystenLabs/sui/releases

mario4tier commented 1 month ago

Issue now open with Mysten Labs: https://github.com/MystenLabs/sui/issues/17770

===

For better user experience in the future, I am considering to implement the following logic:

If the download of the latest succeed but the required binaries are not present, then Suibase will fallback to the previous version (unless being forced in suibase.yaml)

kkomelin commented 1 month ago

Thank you @mario4tier!

mario4tier commented 1 month ago

Suibase will now always ignore macos arm64 v1.25 release and download previous version instead:

image

A new function "is_valid_assets" in __globals.sh can be used to hard code more exclusion in the future.

===

If somehow you must use v1.25 on your setup, then specify "precompiled_bin: false" in suibase.yaml to force a cargo build.

kkomelin commented 1 month ago

@mario4tier Thank you for the work! It's a little bit disappointing. Will we exclude more releases in the future? What did Sui guys answered? I can try to reach them out as well if necessary

mario4tier commented 1 month ago

Mysten has re-release v1.25 with a fix ( https://github.com/MystenLabs/sui/issues/17770 )

I did revert the workaround in Suibase, so everyone should now be able to update to 1.25

@kkomelin Thanks for reporting this.

kkomelin commented 1 month ago

Great @mario4tier. Thank you. That's good news because separate conditions for every buggy version of a dependency could lead the code to a mess.