search

ChainSafe / ChainBridge

🌉 Modular Multi-Directional Blockchain Bridge to interact with Multiple Networks; Ethereum, Ethereum Classic, Substrate, based chains. Stay tuned for ChainBridge Hub!
GNU Lesser General Public License v3.0
475 stars 300 forks source link

UI aborting transfers #700

Closed ChronicSmoke closed 3 years ago

ChronicSmoke commented 3 years ago

Expected Behavior

The UI submits the transaction

Current Behavior

https://user-images.githubusercontent.com/84600919/130490827-635e941c-11bc-479c-b54f-6ab3d2e09932.mp4

image

GregTheGreek commented 3 years ago

I'm assuming this could be due to this and similar lines throughout this file, where we make assumptions on the gasPrice.

It seems that it defaults to a specified gasPrice set in the configuration file. I'm wondering if you removed that it may default to the baseFee instead? If not, there is something wrong with the gas estimation

P1sar commented 3 years ago

This probably and error related to MetaMask since it is estimating gasPrice. Could you please check you MetaMask version, as well as put the screenshots with GasPrice selected on MetaMask when you are sending the transaction

ChronicSmoke commented 3 years ago

MetaMask version 10,0.2 As seen in the video I never get a chance to set the GasPrice in MetaMask when sending the transaction.

FSM1 commented 3 years ago

@GregTheGreek is absolutely correct.

My recommendation would be to remove the gas price being passed into the Approve calls here and here as well as the Deposit call here

GregTheGreek commented 3 years ago

@FSM1 Maybe remove it on the deposit as well ?

P1sar commented 3 years ago

We can't just remove it bcz it will stop working for chains without EIP1559. @enemycnt is already working for the solution.

P1sar commented 3 years ago

@ChronicSmoke While we are working on more global solution (it will be available soon) can you please share the config that used to run the UI

P1sar commented 3 years ago

We have updated the UI to work properly on networks with activated EIP1559. Please update your UI from latest image.

P1sar commented 3 years ago

closing due to inactivity, probably fixed