Restrict the usage of variable nav in asset-index

ChainSafe / PINT

A Polkadot ecosystem index for investors. A self sustaining auction treasury for parachains.

https://polkadotindex.com/

GNU Lesser General Public License v3.0

21 stars 12 forks source link

Restrict the usage of variable nav in asset-index #395

Closed clearloop closed 2 years ago

clearloop commented 3 years ago

Issue summary

sometimes nav represent ratio and sometimes for amount, it's easy to make confuse

Other information and links

mattsse commented 3 years ago

The underlying type is FixedU128 == Price == Ratio. we should definitely unify naming, I'd suggest when we're dealing with fn nav() we use Price since this is essential that, otherwise the NavProvider should return Ratio where applicable.

Redoudou commented 3 years ago

Hey team! Please add your planning poker estimate with ZenHub @clearloop @mattsse