search

ChainSafe / blst-ts

Typescript wrapper for https://github.com/supranational/blst native bindings, a highly performant BLS12-381 signature library
Other
18 stars 13 forks source link

chore: add node v20 support #102

Closed wemeetagain closed 1 year ago

dapplion commented 1 year ago

Some CI for v20 is broken

Main / build-arm (20) (pull_request) Main / build (ubuntu-20.04, 20) (push)

wemeetagain commented 1 year ago

Seems it is flaky. Rerunning fixes it

dapplion commented 1 year ago

Tho why is arm arch so flaky too? On master everything is green

wemeetagain commented 1 year ago

Old versions were failing due to relying on old unsupported versions of debian.

I've removed support for them.

dapplion commented 1 year ago

arm v20 is failing, I would drop support for it in this PR to unlock other archs and debug latter

wemeetagain commented 1 year ago

its also failing in non-arm ubuntu ???

frustratingly, its not failing locally and seeing the error, its hard to see how it could go so wrong... https://github.com/ChainSafe/blst-ts/actions/runs/5147380281/jobs/9286645208?pr=102

it's failing to do string equality?! https://github.com/ChainSafe/blst-ts/blob/6ff826db02a1c5363d30e67785742b85c9172dea/test/spec/index.test.ts#LL137C16-L137C36

wemeetagain commented 1 year ago

Its all passing.... just quite flaky