search

ChainSafe / blst-ts

Typescript wrapper for https://github.com/supranational/blst native bindings, a highly performant BLS12-381 signature library
Other
18 stars 13 forks source link

chore: add darwin/arm64 prebuild support #113

Closed jeluard closed 8 months ago

jeluard commented 8 months ago

A new macos runner has been released. This image runs on M1 architecture, allowing to create prebuilds for darwin/arm64.

jeluard commented 8 months ago

They now pass (after restarting them). I saw them passing before too. For reference the error was:

  1) altair/eth_aggregate_pubkeys
       eth_aggregate_pubkeys_x40_pubkey:
     AssertionError: expected '0xc00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000' to deeply equal null
      at Context.<anonymous> (test/spec/index.test.ts:85:54)
      at processImmediate (node:internal/timers:478:21)

I am not clear how significant this is. Is it only on this specific platform? Or just a flaky test that also happen on other platforms?

It has to be noted that darwin/arm64 users compiles this exact version (potential bu included) on their machine transparently when installing this lib (tests are not run then). So if there's an issue, the newly added prebuild merely surface it.

matthewkeil commented 8 months ago

I am not sure of how we cut a release for this repo. Have only been working on the rebuild stuff. Do you want to sort through how to get this published after you merge @jeluard ? I dont think we need to actually publish a new version but am not sure. You can find the answer in the scripts dir where the binaries get downloaded.