ChainSafe / blst-ts

Typescript wrapper for https://github.com/supranational/blst native bindings, a highly performant BLS12-381 signature library
Other
18 stars 13 forks source link

Incomplete key validation #24

Closed veorq closed 3 years ago

veorq commented 3 years ago

Key validation checks group membership, but should also check that the key is not the point at infinity:

https://github.com/ChainSafe/blst-ts/blob/3f98022903cd5f45dba94454082ea13ef34f4c13/src/lib.ts#L93-L98

See https://tools.ietf.org/html/draft-irtf-cfrg-bls-signature-04#section-2.5. Look at the blst Rust and Go bindings for examlpes of correct impleemntation.