This PR is related to #88 and covers spec testing of fatsAggregateVerify
_note: I was unable to rectify phase0/fast_aggregate_verify_na_pubkeys_and_infinity_signature and altair/eth_fast_aggregate_verify_na_pubkeys_and_infinity_signature with c. The spec tests for identical conditions that changed between forks. Without programmatic knowledge of the fork its not possible to return both true and false for the same conditions. I used the method in the existing spec tests of checking in the wrapper function that converts the spec name to the correct function here_
Inclusions
Spec tests and required code changes for fastAggregateVerify
How to test
NOTE: to build and test copy the blst folder into rebuild/deps/blst. This will go away when we merge but for now node-gyp gets heartburn when building deps in folder above the binding.gyp file
Unit tests are provided and should have 100% coverage. If you see an edge that may not be covered please feel free to bring it up and I will add the test case
cd rebuild
yarn
yarn build
yarn test:unit
yarn test:spec
This PR is related to #88 and covers spec testing of
fatsAggregateVerify
_note: I was unable to rectify
phase0/fast_aggregate_verify_na_pubkeys_and_infinity_signature
andaltair/eth_fast_aggregate_verify_na_pubkeys_and_infinity_signature
with c. The spec tests for identical conditions that changed between forks. Without programmatic knowledge of the fork its not possible to return both true and false for the same conditions. I used the method in the existing spec tests of checking in the wrapper function that converts the spec name to the correct function here_Inclusions
fastAggregateVerify
How to test
NOTE: to build and test copy the
blst
folder intorebuild/deps/blst
. This will go away when we merge but for nownode-gyp
gets heartburn when building deps in folder above thebinding.gyp
fileUnit tests are provided and should have 100% coverage. If you see an edge that may not be covered please feel free to bring it up and I will add the test case