ChainSafe / chainbridge-celo

GNU Lesser General Public License v3.0
3 stars 2 forks source link

Rebuild bindings and apply new params #121

Closed P1sar closed 3 years ago

P1sar commented 3 years ago

Rebuild new bindings from solidity updates that should be provided by @lastperson.

Implementation details

resulting signature of Execute method should be looking something like

function executeProposal(
    uint8 chainID,
    uint64 depositNonce,
    bytes memory data,
    bytes32 resourceID,
    bytes memory blockHeaderRLP,
    bytes blockHashPrefix,
    bytes memory blockHashSuffix,
    bytes memory blockHashBLSHints,
    bytes memory blockHashSignature,
    bytes memory aggregatePublicKey,
    bytes memory merkleKey,
    bytes memory merkleNodes
)

regenerate bindigns and add params that were added in previous issues

Testing details

E2E could be falling here bcs celo-boostrap will contain old smart contracts. Ask @P1sar to rebuild it.

Acceptance Criteria

waymobetta commented 3 years ago

Found executeProposal in Bridge.sol from celo-solidity showing outdated function signature?

 function executeProposal(
        uint8 chainID,
        uint64 depositNonce,
        bytes memory data,
        bytes32 resourceID,
        bytes memory signatureHeader,
        bytes memory aggregatePublicKey,
        bytes32 hashedMessage,
        bytes32 rootHash,
        bytes memory key,
        bytes memory nodes
    ) 

Maybe a branch has not been merged yet?

P1sar commented 3 years ago

Smart contracts were not changed yet. That is why this issue is in the very end of milestone.