ChainSafe / chainbridge-celo

GNU Lesser General Public License v3.0
3 stars 2 forks source link

Add encoding of APK and Signature for contract readability #123

Closed waymobetta closed 3 years ago

waymobetta commented 3 years ago

Description

In order to further validate proofs on the contract side, some additional encoding of SignatureVerification struct fields is required.

This PR specifically targets the following fields:

Note: In order for this to be tested either Celo PR #23 needs to be merged or the go.mod needs to be modified to replace the celo-bls-go package with the cloned, local version of the referenced celo-bls-go package with the branch kobigurk/arkworks checked out.

Related Issue Or Context

Closes: #120

How Has This Been Tested? Testing details.

Types of changes

Checklist:

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 43c28ea528f605d604ae21a6eb44c556b70d80e0 into cd8bf832b9b64380cb298ef78af1fd2aa92f3041 - view on LGTM.com

new alerts: