search

ChainSafe / chainbridge-celo

GNU Lesser General Public License v3.0
3 stars 2 forks source link

Support of blockConfirmations config parameter #95

Closed P1sar closed 3 years ago

P1sar commented 3 years ago

blockConfirmations is the chain configuration parameter that is responsible for number of blocks to wait before processing a block and parsing it for events. It does saves us from problems related to blocks reorganisation. We already have hardcoded var BlockDelay so make it configurable https://github.com/ChainSafe/chainbridge-celo/blob/d39cd7fb541edc46ae245229bcd96eaeb3d581ff/chain/listener/listener.go#L25

Implementation details

add blockConfirmations parametr support to listeners, so listener will wait specified number of blocks before processing it

Testing details

Write unit tests

Acceptance Criteria

ansermino commented 3 years ago

Does this make sense for Celo? Since they are POS won't they have non-probabilistic finality?

P1sar commented 3 years ago

Change blockConfirmations from 10 blocks to 1