chore: update metamask version

ChainSafe / dappeteer

[DEPRECATED]🏌🏼‍E2E testing for dApps using Puppeteer + MetaMask

Other

491 stars 152 forks source link

chore: update metamask version #209

Closed Lykhoyda closed 1 year ago

Lykhoyda commented 1 year ago

Updated recommended metamask version

Short description of work done

PR Checklist

[X] I have run linter locally
[X] I have run unit and integration tests locally
- [ ] Update configuration the newest version (readme and const)
[ ] Rebased to master branch / merged master

Changes

EXAMPLE - Removed basic auth from the controller

Issues

Closes #

Tbaut commented 1 year ago

The flask doesn't seem happy with the "Connect" button. Did they change the name?

mpetrunic commented 1 year ago

The flask doesn't seem happy with the "Connect" button. Did they change the name?

Could be

Lykhoyda commented 1 year ago

The flask doesn't seem happy with the "Connect" button. Did they change the name?

No, they didn't change, it's failing only on CI

mpetrunic commented 1 year ago

The flask doesn't seem happy with the "Connect" button. Did they change the name?

No, they didn't change, it's failing only on CI

do we have retry? This error is usually related to popups which are a tricky thing as we need to refresh after they are ready to ensure we bring them to the front so checkout retry policy if we have one there.

Lykhoyda commented 1 year ago

o we have retry? This error is usually related to popups which are a tricky thing as we need to refresh after they are ready to ensure we bring them to the front so checkout retry policy if we have one there.

Tried to add retry, but it doesn't work on CI. We probably should create an story for that