feat: set default headless mode

ChainSafe / dappeteer

[DEPRECATED]🏌🏼‍E2E testing for dApps using Puppeteer + MetaMask

Other

491 stars 152 forks source link

feat: set default headless mode #239

Closed Lykhoyda closed 1 year ago

Lykhoyda commented 1 year ago

Set headless version true as a default parameter Short description of work done

PR Checklist

[x] I have run linter locally
[x] I have run unit and integration tests locally
- [ ] Update configuration the newest version (readme and const)
[x] Rebased to master branch / merged master

Changes

EXAMPLE - Removed basic auth from the controller

Issues

Closes #

Lykhoyda commented 1 year ago

I think that headless option can be "merged", I don't see the point of having it separated

I didn't get your idea. Do you mean making it a parameter outside the puppeteer and playwright configuration? As a generic for both?

BeroBurny commented 1 year ago

I think that headless option can be "merged", I don't see the point of having it separated

I didn't get your idea. Do you mean making it a parameter outside the puppeteer and playwright configuration? As a generic for both?

yup