Closed marijanabevanda closed 9 months ago
I don't know why Playwright is failing. The error seems (and should be) unrelated to my recent changes, and I've also encountered another on the master branch.
Playwright error:
Local error on master branch:
I don't know why Playwright is failing. The error seems (and should be) unrelated to my recent changes, and I've also encountered another on the master branch.
Playwright error:
Local error on master branch:
I'm aware of that issue, working on a dappeter update to latest mm version, so it will be addressed in upcoming PR.
Short description of work done Fixing 'Node is Detached from Document' Error in Puppeteer/Dappeteer Code: Refactoring closeWhatsNewModal Logic
PR Checklist
Changes
I encountered an intermittent 'Node is detached from document' error while using the closeWhatsNewModal method. This issue occurred sporadically due to the dynamic nature of the application, where the close button was deleted and recreated.
To address this problem, I implemented a solution similar to what was used in the closePopup method. Specifically, I introduced a new method called evaluateElementClick that contains the necessary logic. This method includes a 1-second delay to handle scenarios where elements are dynamically recreated. Both closePopup and closeWhatsNewModal methods now use evaluateElementClick.
(Added new pull request because last wasn't working with cla)
Error solved:![image](https://github.com/ChainSafe/dappeteer/assets/54986853/e6cceb08-1911-4c27-b55b-34c34d5c881d)
Issues
Closes #