ChainSafe / discv5

A Typescript implementation of the Discv5 protocol
Apache License 2.0
28 stars 15 forks source link

`lru-cache` is devDependency #252

Closed acolytec3 closed 1 year ago

acolytec3 commented 1 year ago

In upgrading some dependencies for Ultralight, I noticed some issues related to lru-cache in discv5. I'm not 100% sure this is the source of our issues but this dependency is directly imported in the session/service.ts file but is only declared as a devDependency in package.json

Would you be open to a PR moving this to the dependencies property so we can see it properly within Ultralight's dependency tree?

wemeetagain commented 1 year ago

Ah yes this definitely looks like a bug. lru-cache should be listed as a dependency

acolytec3 commented 1 year ago

Resolved by #253