search

ChainSafe / discv5

A Typescript implementation of the Discv5 protocol
Apache License 2.0
28 stars 15 forks source link

chore: remove dgram from package.json #262

Closed acolytec3 closed 1 year ago

acolytec3 commented 1 year ago

Removes dgram as a dependency as this is a core Nodejs module now. Will also keep this npm warning message from appearing when installing dependencies for discv5.

npm WARN deprecated dgram@1.0.1: npm is holding this package for security reasons. As it's a core Node module, we will not transfer it over to other users. You may safely remove the package from your dependencies.

wemeetagain commented 1 year ago

Can you also replace the line import ... from "dgram" with import ... from "node:dgram"?

acolytec3 commented 1 year ago

Can you also replace the line import ... from "dgram" with import ... from "node:dgram"?

Done!

acolytec3 commented 1 year ago

Why the switch from dgram to node:dgram? That seems to confuse Typescript (even though we have the @types/node devDependency already.

nflaig commented 1 year ago

@types/node is still on version 12, should update that to 20 which then also has the types for dgram