search

ChainSafe / engineering-handbook

ChainSafe Engineering Handbook
https://handbook.chainsafe.io
Apache License 2.0
6 stars 2 forks source link

Add Typescript monorepo section #28

Closed mpetrunic closed 1 year ago

render[bot] commented 2 years ago

Your Render PR Server URL is https://engineering-handbook-pr-28.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9t2hp79re0kgdo5f45g.

mpetrunic commented 2 years ago

@wemeetagain updated with commands for bumping versions.

wemeetagain commented 2 years ago

Do we want to try out the steps in lodestar to see how it goes? see if anything important is missing?

dapplion commented 2 years ago

TBH I'm just thinking we don't we just use npm? What's the issue with the default tool?

mpetrunic commented 2 years ago

TBH I'm just thinking we don't we just use npm? What's the issue with the default tool?

🤷🏻‍♂️ You loose ability to run commands only in changed workspaces (which would improve lodestar dev workflow I imagine) and you end up with bugs using npm versions instead of linked if you forgot to update + you need custom or third party tools to manage versions

wemeetagain commented 2 years ago

Adding the yarn source is probably the least of our worries wrt our repo size. Much bigger is the full prometheus binary deep in history 🤣

dapplion commented 2 years ago

You loose ability to run commands only in changed workspaces (which would improve lodestar dev workflow I imagine)

We technically already support that https://github.com/ChainSafe/lodestar/blob/292b36d0c1e216fe39c06a3ddcb1a255808b0b78/package.json#L17

mpetrunic commented 2 years ago

You loose ability to run commands only in changed workspaces (which would improve lodestar dev workflow I imagine)

We technically already support that https://github.com/ChainSafe/lodestar/blob/292b36d0c1e216fe39c06a3ddcb1a255808b0b78/package.json#L17

Does it work on windows and mac? 😛

dapplion commented 2 years ago

You loose ability to run commands only in changed workspaces (which would improve lodestar dev workflow I imagine)

We technically already support that https://github.com/ChainSafe/lodestar/blob/292b36d0c1e216fe39c06a3ddcb1a255808b0b78/package.json#L17

Does it work on windows and mac? stuck_out_tongue

mac it should, windows we don't have any devs on windows atm

mpetrunic commented 1 year ago

@dapplion @wemeetagain Updated to use corepack, no need to commit yarn version anymore 🎉

mpetrunic commented 1 year ago

merging this as nobody commented for a long time