search

ChainSafe / engineering-handbook

ChainSafe Engineering Handbook
https://handbook.chainsafe.io
Apache License 2.0
5 stars 2 forks source link

Run deploy only after successull check #89

Closed kalambet closed 1 year ago

kalambet commented 1 year ago

Description

This PR updates GH Actions workflow so it runs CfloudFlare Page deploy only after CI check compelted successfully.

mpetrunic commented 1 year ago

Will this work? isnt cloudflare deploy relying on some push event details like ref?

kalambet commented 1 year ago

@mpetrunic Ideally it would be nice to disable CloudFlare autodeploy on the ClpudFlare side completly (you can check how Gaming Docs are working). Bc right now we are sorta have two deploys. One initiated by watchers of the repo on CloudFlare side and another one initiated by GitHub Actions.

If we are proactively doing deploy from here you do not need git ref or anything. The buld is actually happening inside GH Action.

The downside - there is no nice comment with deployerd URL inside PR itslef. The plus side - you still can see this data in the comment on GitHub workflow page like this: https://github.com/ChainSafe/game-docs-v2/actions/runs/4234551979

mpetrunic commented 1 year ago

@mpetrunic Ideally it would be nice to disable CloudFlare autodeploy on the ClpudFlare side completly (you can check how Gaming Docs are working). Bc right now we are sora have two deploys. One initiated by watchers of the repo on CloudFlare side and another one initiated by GitHub Actions.

If we are proactively doing deploy from here you do not need git ref or anything. The buld is actually happening inside GH Action.

The downside - there is no nice comment with deployerd URL inside PR itslef. The plus side - you still can see this data in the comment on GitHub workflow page like this: https://github.com/ChainSafe/game-docs-v2/actions/runs/4234551979

Another downside is that Cloudflare keeps the URL the same if you push from the same ref. We could figure out a way to hack but maybe it's easier to add to the ci script as the last task?

mpetrunic commented 1 year ago

But also cloudflare deploy didn't even run here or created a deployment here

kalambet commented 1 year ago

Yep, that is becasue workflow_run is not triggering until it's on the default branch. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

There second Note about it. But after the merge it works as expected. The Gaming Docs repo working in this exact way.

kalambet commented 1 year ago

The only thing that I generally wanted to achieve here is to make sure build is happening on the GH Actions side and we will not have the same problem as with Render when sometimes their watchers was broken or sometimes did not even report the problem back.



But I'm totally open for any other solutions to this.

kalambet commented 1 year ago

Oh, yes, agree. Let me add docs also to this PR so it is more or less a single package. And if we decide to roll it back we will remove the related docs too.

kalambet commented 1 year ago

Ah, I just realised that this one is closed. Will create another one.

mpetrunic commented 1 year ago

Ah, I just realised that this one is closed. Will create another one.

I already opened one https://github.com/ChainSafe/engineering-handbook/pull/92 But feel free to add reasoning regarding workflow trigger there!

mpetrunic commented 1 year ago

@kalambet Maybe take a look at https://github.com/ChainSafe/engineering-handbook/pull/93