ChainSafe / fil-actor-states

State handling crates for the Filecoin Actors
Apache License 2.0
3 stars 2 forks source link

[Feature] deal_provider_collateral_bounds. #272

Closed ruseinov closed 5 months ago

ruseinov commented 5 months ago

Summary of changes Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

needs to be tested on forest first, once finalized could be reviewed and merged.

ruseinov commented 5 months ago

Now that I have realized that the actor code is actually copied from https://github.com/filecoin-project/builtin-actors, I'd say that we need to:

  1. Introduce a shared helper for actor versions that don't define the deal_provider_collateral_bounds method (v8-v10).
  2. Use the OG methods for other versions
  3. Upgrade README.md with the reasoning as to why we can't actually introduce helpers for future versions (because that code is copied from the OG repo).
ruseinov commented 5 months ago

@LesnyRumcajs ready for re-review. feel free to merge when done