chore: no cids definitions in this repo

ChainSafe / fil-actor-states

State handling crates for the Filecoin Actors

Apache License 2.0

3 stars 2 forks source link

chore: no cids definitions in this repo #319

Closed LesnyRumcajs closed 1 month ago

LesnyRumcajs commented 1 month ago

Summary of changes Changes introduced in this pull request:

purged the CID-specific code from this repository, along with Go code and its parsing.

Reference issue to close (if applicable)

Closes

Other information and links

ruseinov commented 1 month ago

Looks good!

Does this have it's forest counterpart already? I'm assuming this is going to break a bunch of things, so it'd be nice to actually have the forest integration ready before we merge this.

LesnyRumcajs commented 1 month ago

Looks good!

Does this have it's forest counterpart already? I'm assuming this is going to break a bunch of things, so it'd be nice to actually have the forest integration ready before we merge this.

Yes. https://github.com/ChainSafe/forest/pull/4564

ruseinov commented 1 month ago

Looks good! Does this have it's forest counterpart already? I'm assuming this is going to break a bunch of things, so it'd be nice to actually have the forest integration ready before we merge this.

Yes. ChainSafe/forest#4564

Perfect. Happy to approve this once the above is green!

LesnyRumcajs commented 1 month ago

Looks good! Does this have it's forest counterpart already? I'm assuming this is going to break a bunch of things, so it'd be nice to actually have the forest integration ready before we merge this.

Yes. ChainSafe/forest#4564

Perfect. Happy to approve this once the above is green!

It's green except for the cargo dependencies which are to be adjusted to a new release anyway.