ChainSafe / fil-actor-states

State handling crates for the Filecoin Actors
Apache License 2.0
3 stars 2 forks source link

Align actor dependencies versioning with the builtin-actors #58

Closed LesnyRumcajs closed 1 year ago

LesnyRumcajs commented 1 year ago

We must align the dependencies to have them on par with the builtin-actors. Otherwise, we end up in a situation where we cannot resolve a delegated address as the method accepts only FVM2 Address, and the conversion is not possible. https://github.com/ChainSafe/fil-actor-states/blob/main/init_v10/src/state.rs#L78

So, taking as an example this Cargo file https://github.com/ChainSafe/fil-actor-states/blob/main/init_v10/Cargo.toml

The versions there must match whatever was used at the time of the release of v10 actors in https://github.com/filecoin-project/builtin-actors/blob/master/actors/init/Cargo.toml#L19, most notably FVM3, which is not compatible with the FVM2.

The same goes for all other actors.

The priority is to have the v10 dependencies aligned. Later, we should ensure that v9 and v8 also use the correct versioning.

lemmih commented 1 year ago

@sudo-shashank if you could have a look that'd be fantastic, unfortunately it's a blocker, at least having fvm3 in v10 actors.

sudo-shashank commented 1 year ago

we are aligned to all necessary dependencies like fvm, fvm_shared, etc but not aligned on the crates that are backwards compatible like frc42_dispatch, frc46_token, fvm_ipld_encoding, fvm_ipld_hamt, etc