search

ChainSafe / filsnap

MetaMask snap for interacting with Filecoin dapps.
https://filsnap.chainsafe.io
Apache License 2.0
107 stars 41 forks source link

[bug]: FILSnap@2.3.5 broken in prod #191

Closed rekmarks closed 2 years ago

rekmarks commented 2 years ago

Describe the bug

The MetaMask team noticed that FILSnap@2.3.5 cannot be installed because the path fields in its snap.manifest.json are prefixed with ./. This is not permitted by the manifest specification.

We are nevertheless going to permit this for Snaps published to npm in the future, and this change will be included in a release Soon(TM). That said, the quickest way to fix this is probably to fix the manifest fields and re-release the snap.

To Reproduce

  1. Ensure that FILSnap is not installed in your current instance of MetaMask Flask
  2. Go to https://filsnap.chainsafe.io/
  3. Attempt to install FILSnap
  4. Notice that installation fails

Relevant log output

n/a

Expected behavior

Installation should work.

Additional context

n/a

mpetrunic commented 2 years ago

@rekmarks should this check be added to snaps-cli validate manifest command?