ChainSafe / filsnap

MetaMask snap for interacting with Filecoin dapps.
https://filsnap.chainsafe.io
Apache License 2.0
107 stars 41 forks source link

fix: issues after MetaMask update with breaking changes #244

Closed navFooh closed 1 year ago

navFooh commented 1 year ago

Fixes the following issues:

Something seems to go wrong with linking the packages when running the demo locally, since I get the following error:

Failed to compile.
./src/containers/MetaMaskConnector/MetaMaskConnector.tsx
Module not found: Can't resolve '@chainsafe/filsnap-adapter' in 'C:\dev\chainsafe\filsnap\packages\example\src\containers\MetaMaskConnector'

However, I've been able to test the RPC changes in my local project and that seems to work fine. The only problem is that I still get the error about the snap permissions and I'm not sure if we can even test that properly without first deploying the new snap version and installing it in MetaMask.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

navFooh commented 1 year ago

Fixes: https://github.com/ChainSafe/filsnap/issues/243

BeroBurny commented 1 year ago

Thanks for taking the time to contribute to a project, we appreciate any community help.

Most of the PR looks good but it covering breaking changes related to the adapter, unfortunate there is more related to the snap itself, @irubido can you please check in detail? (even merge and do rest work on top of it)

irubido commented 1 year ago

Hi @navFooh I appreciate the effort of updating filsnap, adapter changes you made are on the right track, there's just a couple of more things are needed with it, and updating snap itself. I already started working on the updating filsnap adapter and snap, and PR will be ready soon. Thanks for your effort

navFooh commented 1 year ago

Hi @irubido, My pleasure! Good to hear that you're working on it.

BeroBurny commented 1 year ago

Unfortunaly we are not going to merge this in favor of #246

Thanks for participating and attempting to contribute to a project. We appreciate your effort :pray:

navFooh commented 1 year ago

My pleasure! Thank you for maintaining this project 🙏