Closed navFooh closed 1 year ago
Thanks for taking the time to contribute to a project, we appreciate any community help.
Most of the PR looks good but it covering breaking changes related to the adapter, unfortunate there is more related to the snap itself, @irubido can you please check in detail? (even merge and do rest work on top of it)
Hi @navFooh I appreciate the effort of updating filsnap, adapter changes you made are on the right track, there's just a couple of more things are needed with it, and updating snap itself. I already started working on the updating filsnap adapter and snap, and PR will be ready soon. Thanks for your effort
Hi @irubido, My pleasure! Good to hear that you're working on it.
Unfortunaly we are not going to merge this in favor of #246
Thanks for participating and attempting to contribute to a project. We appreciate your effort :pray:
My pleasure! Thank you for maintaining this project 🙏
Fixes the following issues:
wallet_enable
method has been replaced withwallet_requestSnaps
, passing params as an object, not an array. https://docs.metamask.io/guide/snaps-rpc-api.html#wallet-requestsnapswallet_snap_*
should now be sent with the params as a single object, not as an array. https://docs.metamask.io/guide/snaps-rpc-api.html#wallet-snapendowment:rpc
permission should now be granted to the snap in order to receive RPC calls. My assumption is that only thedapps
property needs to be true and not thesnaps
property. https://docs.metamask.io/guide/snaps-permissions.html#endowment-rpcSomething seems to go wrong with linking the packages when running the demo locally, since I get the following error:
However, I've been able to test the RPC changes in my local project and that seems to work fine. The only problem is that I still get the error about the snap permissions and I'm not sure if we can even test that properly without first deploying the new snap version and installing it in MetaMask.