search

ChainSafe / filsnap

MetaMask snap for interacting with Filecoin dapps.
https://filsnap.chainsafe.io
Apache License 2.0
107 stars 41 forks source link

fix: Update shasum for MetaMask Flask version 10.31.0-flask.0 #260

Closed vorburger closed 1 year ago

vorburger commented 1 year ago

I suspect this should fix #258.

Can I get some... FIL... something... GitCoin... whatever... 🥇 appreciation 😼 for this?

vorburger commented 1 year ago

license/cla Expected — Waiting for status to be reported

How / where do I sign your CLA?

mpetrunic commented 1 year ago

license/cla Expected — Waiting for status to be reported

How / where do I sign your CLA?

We don't have CLA on this repo, status check was some remnant from before

vorburger commented 1 year ago

@mpetrunic ACK, the CLA Check has now disappeared. But there is now a build failure due to:

Run echo "Snap manifest not updated: packages/snap/snap.manifest.json"
Snap manifest not updated: packages/snap/snap.manifest.json
Error: Process completed with exit code [1](https://github.com/ChainSafe/filsnap/actions/runs/5171557832/jobs/9321252724?pr=260#step:10:1).

which... doesn't really make a whole lot of sense? This PR IS updating packages/snap/snap.manifest.json, so there must be something wrong with that check.

mpetrunic commented 1 year ago

@mpetrunic ACK, the CLA Check has now disappeared. But there is now a build failure due to:

Run echo "Snap manifest not updated: packages/snap/snap.manifest.json"
Snap manifest not updated: packages/snap/snap.manifest.json
Error: Process completed with exit code [1](https://github.com/ChainSafe/filsnap/actions/runs/5171557832/jobs/9321252724?pr=260#step:10:1).

which... doesn't really make a whole lot of sense? This PR IS updating packages/snap/snap.manifest.json, so there must be something wrong with that check.

Just checked locally, you didn't do something right, the shasum on master is the correct one. What commands did you run to get this sha?

vorburger commented 1 year ago

Just checked locally, you didn't do something right, the shasum on master is the correct one.

@mpetrunic nope, I have to most respectfully disagree with you, that seems to be broken, and causes https://github.com/ChainSafe/filsnap/issues/258, as also reported e.g. on https://github.com/ChainSafe/filsnap/issues/257, because of https://github.com/MetaMask/snaps/issues/1304, as confirmed by @FrederikBolding. To the best of my knowledge, this PR should fix that issue. Perhaps you could consider re-opening this PR?

What commands did you run to get this sha?

I have documented that here.

mpetrunic commented 1 year ago

You forgot to update snaps-cli and build error related to that update in your PR. Replaced by #261