Closed samuelarogbonlo closed 3 months ago
Any reason you omitted these?
images/snapshot-service/src/upload_snapshot.sh|71 col 40| for i in {1..5}; do aria2c -x5 https://forest-archive.chainsafe.dev/latest/$CHAIN_NAME/ && break || sleep 15; done
tf-managed/modules/snapshot-monitoring/README.md|4 col 12| - <https://forest-archive.chainsafe.dev/mainnet/latest/>
tf-managed/modules/snapshot-monitoring/README.md|5 col 12| - <https://forest-archive.chainsafe.dev/calibnet/latest/>
LGTM. Just one nit, from a normal user's perspective, internal
in the URL is a bit surprising and makes me double check if it's the proper link, public
look more proper to me
LGTM. Just one nit, from a normal user's perspective,
internal
in the URL is a bit surprising and makes me double check if it's the proper link,public
look more proper to me
To my understanding, the entire internal
(and so quite a bit of code in this repository) will soon go, and before that, it shouldn't be used outside of the Forest team.
Any reason you omitted these?
images/snapshot-service/src/upload_snapshot.sh|71 col 40| for i in {1..5}; do aria2c -x5 https://forest-archive.chainsafe.dev/latest/$CHAIN_NAME/ && break || sleep 15; done tf-managed/modules/snapshot-monitoring/README.md|4 col 12| - <https://forest-archive.chainsafe.dev/mainnet/latest/> tf-managed/modules/snapshot-monitoring/README.md|5 col 12| - <https://forest-archive.chainsafe.dev/calibnet/latest/>
@LesnyRumcajs None just missed them.
Summary of changes Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links