search

ChainSafe / forest

🌲 Rust Filecoin Node Implementation
https://forest.chainsafe.io
Apache License 2.0
638 stars 160 forks source link

interpreter tests are just copy-pasted #3547

Open aatifsyed opened 1 year ago

aatifsyed commented 1 year ago

https://github.com/ChainSafe/forest/blob/f54d8d7f31ed5f1c8f96819e0a800c5466da71a6/src/interpreter/fvm2.rs#L297-L327 https://github.com/ChainSafe/forest/blob/f54d8d7f31ed5f1c8f96819e0a800c5466da71a6/src/interpreter/fvm3.rs#L319-L349 https://github.com/ChainSafe/forest/blob/f54d8d7f31ed5f1c8f96819e0a800c5466da71a6/src/interpreter/fvm4.rs#L319-L349

Needs refactoring

aatifsyed commented 1 year ago

How much of the fvm code is copy-paste? I suspect it needs a bunch of refactoring