Add support for Eth mappings - Githubissues

ChainSafe / forest

🌲 Rust Filecoin Node Implementation

https://forest.chainsafe.io

Apache License 2.0

632 stars 153 forks source link

Add support for Eth mappings #4400

Closed elmattic closed 3 months ago

elmattic commented 3 months ago

Summary of changes

Changes introduced in this pull request:

Introduce a new ParityDB namespace for storing Ethereum mappings such as Hash to TipsetKey and Hash to message Cid. This is required by methods like:
- EthGetBlockByHash
- EthGetBlockTransactionCountByHash
- EthGetMessageCidByTransactionHash
Increment Forest version to 0.19.0

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

ruseinov commented 3 months ago

Some things to consider: https://github.com/ChainSafe/forest/blob/6f60fedc52a10d8575a6f06950fb278476dedbb0/src/db/parity_db.rs#L126 needs to account for the new column as well as all the places this method is being called.

This could prove a little complicated, because right now we reply on codec type coming from fvm_ipld_encoding to detect the column type. Now that we have introduced one more column type it's going to prove difficult, unless we introduce a bogus codec just for that.

EDIT: Nevermind, all of this code is bypassed. But it would be nice to have this properly documented.