ChainSafe / forest

🌲 Rust Filecoin Node Implementation
https://forest.chainsafe.io
Apache License 2.0
618 stars 145 forks source link

feat(rpc): implement Filecoin.StateListActors #4409

Closed hanabi1224 closed 3 weeks ago

hanabi1224 commented 3 weeks ago

Summary of changes

Changes introduced in this pull request:

     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-06-12_height_1694998.forest.car.zst --filter StateListActors`
| RPC Method                    | Forest | Lotus |
|-------------------------------|--------|-------|
| Filecoin.StateListActors (10) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

hanabi1224 commented 3 weeks ago

Missing a CHANGELOG entry.

@ruseinov I'd prefer not to bloat the changelog(and create potential merge conflicts with others) with an entry for each individual RPC method, maybe better to use a milestone entry instead. Note that we still have the detailed autogenerated changelog for each PR on the release page. Echoing @lemmih 's comment here

I'm okay with not having a changelog entry for each RPC method. Instead, we'll have an entry for each RPC milestone (full v0, full v1, full lotus compliance, etc).

ruseinov commented 3 weeks ago

Missing a CHANGELOG entry.

@ruseinov I'd prefer not to bloat the changelog(and create potential merge conflicts with others) with an entry for each individual RPC method, maybe better to use a milestone entry instead. Note that we still have the detailed autogenerated changelog for each PR on the release page. Echoing @lemmih 's comment here

I'm okay with not having a changelog entry for each RPC method. Instead, we'll have an entry for each RPC milestone (full v0, full v1, full lotus compliance, etc).

I mean we used to put every RPC endpoint into CHANGELOG till now, I see no reason in changing that now. I leave this up to you, I find changing patterns confusing, especially since we've already introduced most of the endpoints.