fix: refactor StateManager::replay to get rid of channels - Githubissues

ChainSafe / forest

🌲 Rust Filecoin Node Implementation

https://forest.chainsafe.io

Apache License 2.0

618 stars 145 forks source link

fix: refactor StateManager::replay to get rid of channels #4420

Closed hanabi1224 closed 2 weeks ago

hanabi1224 commented 2 weeks ago

Summary of changes

To address the original comment

// This isn't ideal to have, since the execution is synchronous, but this needs // to be the case because the state transition has to be in blocking // thread to avoid starving executor let (tx, rx) = flume::bounded(1);

Changes introduced in this pull request:

refactor replay into replay_blocking and replay to avoid using channels

     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-06-18_height_1711826.forest.car.zst --filter StateReplay`
| RPC Method                | Forest | Lotus |
|---------------------------|--------|-------|
| Filecoin.StateReplay (24) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.