ChainSafe / forest

🌲 Rust Filecoin Node Implementation
https://forest.chainsafe.io
Apache License 2.0
617 stars 145 forks source link

fix(rpc test): StateCall and StateReplay #4435

Open hanabi1224 opened 2 weeks ago

hanabi1224 commented 2 weeks ago

Summary of changes

For a detailed explanation, see https://github.com/ChainSafe/forest/issues/4432#issuecomment-2180557858

Changes introduced in this pull request:

Manually tested with the same snapshot that causes CI failures in https://github.com/ChainSafe/forest/actions/runs/9593268587/job/26453560366#step:5:39

forest-tool api compare /data/forest_snapshot_calibnet_2024-06-20_height_1718049.forest.car.zst --forest *** --lotus *** --n-tipsets 10 --filter-file /data/filter-list --miner-address t0111551 --worker-address t3sw466j35hqjbch5x7tcr7ona6idsgzypoturfci2ajqsfrrwhp7ty3ythtd7x646adaidnvxpdr5b2ftcciq
     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-06-20_height_1718049.forest.car.zst --filter StateReplay`
| RPC Method                | Forest | Lotus |
|---------------------------|--------|-------|
| Filecoin.StateReplay (48) | Valid  | Valid |
     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-06-20_height_1718049.forest.car.zst --filter StateCall`
| RPC Method              | Forest | Lotus |
|-------------------------|--------|-------|
| Filecoin.StateCall (48) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

LesnyRumcajs commented 2 weeks ago

I recommend we don't merge this so that it's clearly visible that the Forest and Lotus output differs at the currently used versions.