fix: duplicate schema names - Githubissues

ChainSafe / forest

🌲 Rust Filecoin Node Implementation

https://forest.chainsafe.io

Apache License 2.0

617 stars 145 forks source link

fix: duplicate schema names #4437

Closed aatifsyed closed 2 weeks ago

aatifsyed commented 2 weeks ago

Summary of changes

Fixes this in our generated OpenRPC

{ "components": { "schemas": { "Cid": ..., "Cid2": ... } } }

add an include argument to forest-tool shed openrpc
rename eth::BigInt to eth::EthBigInt, but see #4436
make LotusJson for Vec less special
make LotusJson for Cid less special
<LotusJson as JsonSchema>::schema_id (this fixes most of the bugs)
tweak schemas for SignatureType, Vec,

Change checklist

[x] I have performed a self-review of my own code,
[ ] I have made corresponding changes to the documentation,
[ ] I have added tests that prove my fix is effective or that my feature works (if possible),
[ ] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

ruseinov commented 2 weeks ago

Looks good to me apart from one minor nit.