chore: update multiaddr dns prefix for bootstrap nodes

joshdougall commented 3 months ago

Summary of changes

The list of bootstrap nodes was provided using the /dns4 multiaddr prefix, which limits libp2p connections to IPV4 only. Since the ChainSafe Infrastructure team has added IPV6 support to their bootstrap nodes, this change introduces a node's ability to join using either IPV4 or IPV6 through the DNS path. This change supports nodes that are IPV4 only, as well as those that support IPV4 and IPV6 (ChainSafe & glif.io nodes).

Changes introduced in this pull request:

Multiaddr prefix changed from /dns4 to /dns

Reference issue to close (if applicable)

Closes https://github.com/ChainSafe/infrastructure-general/issues/264

Change checklist

[X] I have performed a self-review of my own code,
[ ] I have made corresponding changes to the documentation,
[ ] I have added tests that prove my fix is effective or that my feature works (if possible),
[ ] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

CLAassistant commented 3 months ago

All committers have signed the CLA.

LesnyRumcajs commented 3 months ago

Are you positive that, e.g., glif hostnames are resolvable to ipv6? From https://github.com/multiformats/multiaddr/blob/master/protocols.csv

dns -   domain name resolvable to both IPv6 and IPv4 address

❯ host -t AAAA calibration.node.glif.io
calibration.node.glif.io is an alias for a2ad5f028b78e4f628b8280d2482e5fa-9805736762487b63.elb.ap-northeast-1.amazonaws.com.

~
❯ host -t AAAA a2ad5f028b78e4f628b8280d2482e5fa-9805736762487b63.elb.ap-northeast-1.amazonaws.com.
a2ad5f028b78e4f628b8280d2482e5fa-9805736762487b63.elb.ap-northeast-1.amazonaws.com has no AAAA record

ChainSafe / forest