search

ChainSafe / forest

🌲 Rust Filecoin Node Implementation
https://forest.chainsafe.io
Apache License 2.0
638 stars 160 forks source link

fix `Filecoin.GasEstimateMessageGas` #4663

Open ansermino opened 3 months ago

ansermino commented 3 months ago

As reported in the curio-dev channel here:

Seems like forest gas estimation is acting up - My Calibnet WindowPoSts failed to send with

error: sending proof message: send error: RPC error (-32603): given message has too high of a gas limit

Snap later failed with

error: pushing message to mpool: send error: RPC error (-32603): gas_limit 0 cannot be less than cost 4958563.000 of storing a message on chain

(lotus-backed sends failed with error: pushing message to mpool: GasEstimateMessageGas error: message execution failed: exit ErrIllegalArgument(16), reason: message failed with backtrace: 00: f0116147 (method 35) -- invalid update 0 while requiring activation success: sector isn't active, skipping sector 29 (16) (RetCode=16) so this one is probably not returning the correct error in Gas Estimation)

Sadly, we have no snapshots of the invalid behaviour.

LesnyRumcajs commented 3 months ago

Updated the issue - the method is implemented, but something is not working right.

LesnyRumcajs commented 2 months ago

Blocked by https://github.com/ChainSafe/forest/issues/4716

LesnyRumcajs commented 1 month ago

Can't replicate right now.

ansermino commented 2 weeks ago

@LesnyRumcajs Please confirm this is unblocked and remove the label if so

LesnyRumcajs commented 2 weeks ago

@ansermino It is not unblocked because it is not actionable given we don't have means of reproducing this. We are waiting on Curio devs on this, given it happen only on their side.