ChainSafe / forest

🌲 Rust Filecoin Node Implementation
https://forest.chainsafe.io
Apache License 2.0
632 stars 153 forks source link

Implement chain events #4740

Open elmattic opened 3 weeks ago

elmattic commented 3 weeks ago

Issue summary

Currently PR #4691 is blocked by the lack of events in Forest.

Task summary

Feel free to break down the issue into new tasks if needed, i.e., a research spike, etc..

Other information and links

Lotus events implementation: https://github.com/filecoin-project/lotus/tree/master/chain/events

Related FIPs:

elmattic commented 3 weeks ago

Here's a non-exhaustive list of methods that are likely blocked by this issue:

LesnyRumcajs commented 3 weeks ago

@elmattic is EthNewPendingTransactionFilter blocked? There's a PR for it https://github.com/ChainSafe/forest/pull/4725. Or does it lack something?

elmattic commented 3 weeks ago

@elmattic is EthNewPendingTransactionFilter blocked? There's a PR for it #4725. Or does it lack something?

We could probably remove this one for now. We should be able to create a new filter even without directly supporting events.

Testing this endpoint properly would require something like Filecoin.EthGetFilterChange, which is on my list.

@sudo-shashank What do you think?

sudo-shashank commented 2 weeks ago

@elmattic is EthNewPendingTransactionFilter blocked? There's a PR for it #4725. Or does it lack something?

We could probably remove this one for now. We should be able to create a new filter even without directly supporting events.

Testing this endpoint properly would require something like Filecoin.EthGetFilterChange, which is on my list.

@sudo-shashank What do you think?

yes the list of methods shared above is blocked on the points mentioned in this issue

LesnyRumcajs commented 2 weeks ago

@elmattic Does it also block these methods? Any others?

elmattic commented 2 weeks ago

Does it also block these methods?

Indeed.

elmattic commented 2 weeks ago

Any others?

SubscribeActorEventsRaw

elmattic commented 2 weeks ago

EthSubscribe as well.