ChainSafe / gossamer

🕸️ Go Implementation of the Polkadot Host
https://chainsafe.github.io/gossamer
GNU Lesser General Public License v3.0
427 stars 110 forks source link

feat(pkg/trie): TrieDB deletes #3984

Closed dimartiro closed 2 weeks ago

dimartiro commented 1 month ago

Changes

Add support for deletes in TrieDB. This deletes will delete nodes from our in-memory structure only.

Summary of changes

Tests

make test

Issues

closes: #3929

timwu20 commented 3 weeks ago

This deletes will delete nodes from our in-memory structure only.

Is there an issue to address deleting nodes from the underlying DB given this closes #3929?

dimartiro commented 3 weeks ago

This deletes will delete nodes from our in-memory structure only.

Is there an issue to address deleting nodes from the underlying DB given this closes #3929?

Good catch, I changed the issue description, I'm addressing everything related with the underlying DB in the commit issue #3993