ChainSafe / gossamer

🕸️ Go Implementation of the Polkadot Host
https://chainsafe.github.io/gossamer
GNU Lesser General Public License v3.0
427 stars 110 forks source link

docs(lib/services): Improve comments of the type ServiceRegistry #4018

Closed EmilGeorgiev closed 17 hours ago

EmilGeorgiev commented 3 weeks ago

Changes

Add more comments to the methods and types.

Issues

closes: #4017

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 3 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.44%. Comparing base (d1ca7aa) to head (74ee529). Report is 118 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #4018 +/- ## =============================================== + Coverage 50.51% 52.44% +1.92% =============================================== Files 230 248 +18 Lines 29006 25598 -3408 =============================================== - Hits 14653 13425 -1228 + Misses 12856 10541 -2315 - Partials 1497 1632 +135 ```
dimartiro commented 2 weeks ago

@EmilGeorgiev could you please check the linter errors by executing make lint ?

EmilGeorgiev commented 2 weeks ago

@EmilGeorgiev could you please check the linter errors by executing make lint ?

Thank you @dimartiro . The PR is updated