search

ChainSafe / gossamer

🕸️ Go Implementation of the Polkadot Host
https://chainsafe.github.io/gossamer
GNU Lesser General Public License v3.0
427 stars 110 forks source link

refactor: remove unnecessary else #4021

Closed EmilGeorgiev closed 2 weeks ago

EmilGeorgiev commented 3 weeks ago

Changes

remove unnecessary else statements.

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

closes: #4020

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (d1ca7aa) to head (6a58aee). Report is 98 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #4021 +/- ## =============================================== + Coverage 50.51% 52.43% +1.91% =============================================== Files 230 244 +14 Lines 29006 25034 -3972 =============================================== - Hits 14653 13127 -1526 + Misses 12856 10339 -2517 - Partials 1497 1568 +71 ```
EmilGeorgiev commented 2 weeks ago

@EmilGeorgiev Love the contributions coming from you. Love the dedication, interest and enthusiasm.

I would however not encourage such changes. I would though let such changes happen as part of other PRs while working on relevant code-parts.

Thank you @kishansagathiya for your time and your review. I understand and I will close the PR.