search

ChainSafe / gossamer

🕸️ Go Implementation of the Polkadot Host
https://chainsafe.github.io/gossamer
GNU Lesser General Public License v3.0
432 stars 116 forks source link

Default minimum number of peers is documented to be 5 but is actually 0 #4252

Closed haikoschol closed 3 weeks ago

haikoschol commented 1 month ago

Describe the bug

According to the CLI documentation, the default for the --min-peers flag is 5. But in the code it is actually set to 0.

Expected Behavior

Documentation reflects what the code actually does.

Current Behavior

The user is bamboozled.

Possible Solution

I don't think 0 is a useful default and therefore suggest setting DefaultMinPeers to 5.

haikoschol commented 1 month ago

fixed by #4257

jimjbrettj commented 3 weeks ago

Reopening since this commit was reverted on dev, so it is still an active issue

haikoschol commented 3 weeks ago

Reclosing, since it was fixed again in #4291. :)