search

ChainSafe / gossamer

🕸️ Go Implementation of the Polkadot Host
https://chainsafe.github.io/gossamer
GNU Lesser General Public License v3.0
432 stars 117 forks source link

Fix(Config Setting): Updated DefaultMinPeers to 5 as per documentation #4252 #4259

Closed programmingwithrp closed 1 month ago

programmingwithrp commented 1 month ago

Changes

According to the CLI documentation, DefaultMinPeers is 5 But in code it was 0. So Updated to 5 as per the documentation

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

4252

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.45%. Comparing base (d1ca7aa) to head (9187b81). Report is 181 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #4259 +/- ## =============================================== + Coverage 50.51% 53.45% +2.93% =============================================== Files 230 297 +67 Lines 29006 30634 +1628 =============================================== + Hits 14653 16374 +1721 + Misses 12856 12368 -488 - Partials 1497 1892 +395 ```
haikoschol commented 1 month ago

@programmingwithrp Thanks for your contribution! However, @raj921 had already opened #4252 which I just merged. Therefore I'm closing this PR.