ChainSafe / js-libp2p-gossipsub

TypeScript implementation of Gossipsub
Apache License 2.0
151 stars 43 forks source link

fix: add rpc error metrics #412

Closed twoeths closed 1 year ago

twoeths commented 1 year ago

Motivation

Description

part of #411

It shows that we really have rpc errors when deploying this branch to a lodestar node

Screen Shot 2023-03-07 at 10 10 16
what-the-diff[bot] commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 32.25% and project coverage change: -0.27 :warning:

Comparison is base (1e1cf5a) 83.31% compared to head (219d2a1) 83.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #412 +/- ## ========================================== - Coverage 83.31% 83.04% -0.27% ========================================== Files 48 48 Lines 11800 11858 +58 Branches 1271 1279 +8 ========================================== + Hits 9831 9848 +17 - Misses 1969 2010 +41 ``` | [Impacted Files](https://codecov.io/gh/ChainSafe/js-libp2p-gossipsub/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe) | Coverage Δ | | |---|---|---| | [src/metrics.ts](https://codecov.io/gh/ChainSafe/js-libp2p-gossipsub/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#diff-c3JjL21ldHJpY3MudHM=) | `20.39% <0.00%> (-0.87%)` | :arrow_down: | | [src/index.ts](https://codecov.io/gh/ChainSafe/js-libp2p-gossipsub/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#diff-c3JjL2luZGV4LnRz) | `70.39% <64.51%> (-0.07%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.