ChainSafe / js-libp2p-gossipsub

TypeScript implementation of Gossipsub
Apache License 2.0
145 stars 43 forks source link

fix!: update stream types #423

Closed achingbrain closed 1 year ago

achingbrain commented 1 year ago

libp2p streams are now explicit about the types of sync/sources they provide, showing that they are AsyncGenerators and not just AsyncIterables.

Refs: https://github.com/achingbrain/it-stream-types/pull/45

BREAKING CHANGE: the type of the source/sink properties have changed

what-the-diff[bot] commented 1 year ago

PR Summary

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 :warning:

Comparison is base (cea6e97) 82.98% compared to head (42e0d1a) 82.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #423 +/- ## ========================================== - Coverage 82.98% 82.96% -0.02% ========================================== Files 48 48 Lines 11874 11878 +4 Branches 1280 1281 +1 ========================================== + Hits 9854 9855 +1 - Misses 2020 2023 +3 ``` | [Impacted Files](https://codecov.io/gh/ChainSafe/js-libp2p-gossipsub/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe) | Coverage Δ | | |---|---|---| | [src/stream.ts](https://codecov.io/gh/ChainSafe/js-libp2p-gossipsub/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#diff-c3JjL3N0cmVhbS50cw==) | `97.46% <100.00%> (+0.13%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/ChainSafe/js-libp2p-gossipsub/pull/423/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.