search

ChainSafe / js-libp2p-gossipsub

TypeScript implementation of Gossipsub
Apache License 2.0
151 stars 43 forks source link

fix: use typed event emitter class #470

Closed achingbrain closed 11 months ago

achingbrain commented 1 year ago

The typed EventEmitter class from @libp2p/interface/events has been renamed TypedEventEmitter along with a TypedEventTarget interface.

The old name is still exported so it's a backwards compatible change but it will be removed in a future version of @libp2p/interface so this change future-proofs @chainsafe/libp2p-gossipsub against that upcoming release.

achingbrain commented 1 year ago

Looks like the custom linting rules in this repo are broken. Upgrading @typescript-eslint/parser may help - or since aegir is being used to build this project, perhaps delete all the custom eslint stuff and just use aegir's linting?

codecov-commenter commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a39115c) 81.35% compared to head (7e2fbe0) 81.35%.

Files Patch % Lines
test/compliance.spec.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #470 +/- ## ========================================== - Coverage 81.35% 81.35% -0.01% ========================================== Files 48 48 Lines 12267 12265 -2 Branches 1291 1291 ========================================== - Hits 9980 9978 -2 Misses 2287 2287 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.