codecov-commenter
commented
1 year ago Codecov Report
Base: 95.19% // Head: 95.27% // Increases project coverage by +0.08% :tada:
Coverage data is based on head (
9a2d126) compared to base (b752604). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #13 +/- ## ========================================== + Coverage 95.19% 95.27% +0.08% ========================================== Files 14 14 Lines 2267 2266 -1 Branches 327 327 ========================================== + Hits 2158 2159 +1 + Misses 109 107 -2 ``` | Flag | Coverage Δ | | |---|---|---| | node | `95.27% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/ChainSafe/js-libp2p-yamux/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe) | Coverage Δ | | |---|---|---| | [src/muxer.ts](https://codecov.io/gh/ChainSafe/js-libp2p-yamux/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#diff-c3JjL211eGVyLnRz) | `91.35% <100.00%> (+0.36%)` | :arrow_up: | | [test/compliance.spec.ts](https://codecov.io/gh/ChainSafe/js-libp2p-yamux/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#diff-dGVzdC9jb21wbGlhbmNlLnNwZWMudHM=) | `100.00% <100.00%> (ø)` | | | [test/util.ts](https://codecov.io/gh/ChainSafe/js-libp2p-yamux/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#diff-dGVzdC91dGlsLnRz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
github-actions[bot]
@libp2p/componentsis a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major@libp2p/componentsmajor has to change too which means every module depending on it also needs a major.Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via
@libp2p/componentsRefs https://github.com/libp2p/js-libp2p-components/issues/6
BREAKING CHANGE: modules no longer implement
Initializableinstead switching to constructor injection