search

ChainSafe / js-libp2p-yamux

Typescript implementation of Yamux
Other
10 stars 8 forks source link

chore: fix linter errors #31

Closed wemeetagain closed 1 year ago

wemeetagain commented 1 year ago

Not sure how the linter was updated without introducing linter errors, but somehow it happened. Fix all linter errors

maschad commented 1 year ago

Yah that's a bit strange because the pr that upgraded aegir to 38.1.0 passed the CI linting check

Also looks like you missed a few errors @wemeetagain

dapplion commented 1 year ago

We shouldn't need to include the package-lock.json

Yes not in this PR but I think all libp2p repos should commit a lock file (either yarn or npm) to ensure consistent DX

achingbrain commented 1 year ago

The breaking linting rules were accidentally included in eslint-config-ipfs@3.1.6 and then reverted shortly afterwards in eslint-config-ipfs@3.1.7 and then re-released as eslint-config-ipfs@4.0.0 - sorry about that.

Master of this repo lints fine right now, this PR isn't strictly necessary at the moment though something like it may be required after the next aegir version.