search

ChainSafe / js-libp2p-yamux

Typescript implementation of Yamux
Other
12 stars 9 forks source link

feat: use libp2p component logger #66

Closed achingbrain closed 10 months ago

achingbrain commented 10 months ago

Refactors code to use the component logger from libp2p to allow more flexible logging patterns.

Refs: https://github.com/libp2p/js-libp2p/issue/2105 Refs: https://github.com/libp2p/js-libp2p/pull/2198 Refs: https://github.com/libp2p/js-libp2p/issue/378

achingbrain commented 10 months ago

65 should be merged into master first, then this PR retargeted to master.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8495ae3) 95.61% compared to head (00e3cb6) 95.52%.

Files Patch % Lines
src/muxer.ts 90.90% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/support-yielding-uint8arraylists #66 +/- ## ========================================================================= - Coverage 95.61% 95.52% -0.09% ========================================================================= Files 14 14 Lines 2210 2211 +1 Branches 329 329 ========================================================================= - Hits 2113 2112 -1 - Misses 97 99 +2 ``` | [Flag](https://app.codecov.io/gh/ChainSafe/js-libp2p-yamux/pull/66/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe) | Coverage Δ | | |---|---|---| | [node](https://app.codecov.io/gh/ChainSafe/js-libp2p-yamux/pull/66/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe) | `95.52% <92.85%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChainSafe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

achingbrain commented 10 months ago

Fixed in https://github.com/ChainSafe/js-libp2p-yamux/pull/65