search

ChainSafe / lodestar-quickstart

Scripts to quick start Lodestar and execution clients on Ethereum.
29 stars 20 forks source link

Client monitoring support #12

Closed nflaig closed 1 year ago

nflaig commented 1 year ago

Currently, there is no easy and documented way to enable client monitoring. Possible option right now would be to add the CLI args to LODESTAR_EXTRA_ARGS but that's not ideal.

A possible solution would be that a user just has to provide the beaconcha.in API key similar to how eth-docker does it or maybe should in general support CL / VC extra args via script parameters (--vcExtras, --clExtras) which would allow more flexibility.

nflaig commented 1 year ago

@g11tech any thoughts on this?

g11tech commented 1 year ago

I guess we can , doesn't hurt to have

nflaig commented 1 year ago

or maybe should in general support CL / VC extra args via script parameters (--vcExtras, --clExtras) which would allow more flexibility.

I would rather tend to just adding this, allows users to configure client monitoring and in general is useful feature

Edit: After further consideration, LODESTAR_EXTRA_ARGS is already the recommended approach to adding extra args such as --checkpointSyncUrl. Having this option via CLI flags might not be needed, maybe should just mentioned LODESTAR_EXTRA_ARGS in the README.