ChainSafe / lodestar-quickstart

Scripts to quick start Lodestar and execution clients on Ethereum.

29 stars 20 forks source link

Comment typo in setup.sh in line 297 #14

Open dranol2021 opened 1 year ago

dranol2021 commented 1 year ago

https://github.com/ChainSafe/lodestar-quickstart/blob/main/setup.sh I am not quite sure, but I think there is a minor comment typo in the setup.sh script in line 297:

Instead of

keystoreDir is where the keystores are to be expected, ...

it should be

keystoresDir is where the keystores are to be expected, ...

philknows commented 1 year ago

@g11tech Correct me if I'm wrong, I don't think this is a typo here specifically as it refers to how setup.sh handles the keystores directory and referencing it internally as keystoreDir.

Maybe we should keep it consistent and change it all to use keystoresDir as a reference?

g11tech commented 12 months ago

correct @philknows , its internal docker mount point, could be changed to keystoresDir, will include it in a future PR