ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.14k stars 280 forks source link

Metrics to add tracker #2468

Open dapplion opened 3 years ago

dapplion commented 3 years ago

Ready to execute

Metric ideas

Misc

Once properly defined, convert to issue or pull request and move above to "Ready to execute"

From Lighthouse

Reviewed this file and select interesting metrics to add https://github.com/sigp/lighthouse/blob/stable/beacon_node/beacon_chain/src/metrics.rs

Block Delay Metrics

Persisting BeaconChain components to disk

Chain Head

g11tech commented 3 years ago

assign please

g11tech commented 3 years ago

@dapplion these looks like good metrics to pick up next ?

dapplion commented 3 years ago

@dapplion these looks like good metrics to pick up next ?

I think the next interesting group to add would be around block production. Note that lighthouse has very detailed timings on each step of the process. Our approach to block production is more simple so maybe a single histogram around the entire thing would suffice. We are already kind of tracking it via the API response times, but it would be nice to track it anyway.

At the same time it would be quite a priority to have metrics in our regen / state cache: https://github.com/ChainSafe/lodestar/issues/2153. Let's discuss details in that issue if you are interested.

dapplion commented 3 years ago

Keeping open since there are some metrics we want to implement soonish too

philknows commented 1 year ago

Adding some ideas to this from @wemeetagain discussion in Columbia that I found in my notes: