ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.19k stars 291 forks source link

Un-subscribe all gossip when reverting to finalized sync #4015

Open dapplion opened 2 years ago

dapplion commented 2 years ago

Currently we un-subscribe core topics when going to finalized sync

https://github.com/ChainSafe/lodestar/blob/2ed2e03d0ca3e2d6e04e503d4e1beb2deedd47a7/packages/lodestar/src/sync/sync.ts#L193-L194

However we keep subnet subscriptions, which are actually the ones taking the bulk of CPU processing.

From https://github.com/ChainSafe/lodestar/issues/2488

philknows commented 1 year ago

Please investigate @tuyennhv , this may already be completed.

wemeetagain commented 1 month ago

This has not been completed, still a real feature request

twoeths commented 1 month ago

will look into this