search

ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.18k stars 289 forks source link

Upgrade fastify to v4.x #4219

Closed wemeetagain closed 1 year ago

wemeetagain commented 2 years ago

Currently at 3.x

The dependencies (fastify-cors, etc) and their types are not great, should all be updated

dapplion commented 2 years ago

@wemeetagain is there any specific reason to bump besides the types? Check the changelog if there many changes that we want

wemeetagain commented 2 years ago

I had problems during #4114 with their types

wemeetagain commented 2 years ago

Also seeing this at startup time:

(node:1506517) [FST_MODULE_DEP_FASTIFY-CORS] FastifyWarning.fastify-cors: fastify-cors has been deprecated. Use @fastify/cors@7.0.0 instead.
philknows commented 2 years ago

We should discuss the priority on this one @dapplion

mpetrunic commented 2 years ago

FYI you don't have to update to 4.x to fix that. You have versions here https://github.com/ChainSafe/gavel-server/pull/1/files if you want to stay at version 3.

Not sure how stable 4.x is since they released it a month or two ago and they seem to be pushing a lot of fixes.

wemeetagain commented 1 year ago

Already updated to 4.15.0.