search

ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.18k stars 289 forks source link

Enable the skipped e2e tests #5967

Open nazarhussain opened 1 year ago

nazarhussain commented 1 year ago

Describe the bug

There are couple of e2e tests which are not skipped but we forget to track those.

Expected behavior

There should be no skipped tests. https://github.com/ChainSafe/lodestar/blob/0b43ef7968a82c1e27034a844e353bba9b944f09/packages/beacon-node/test/e2e/doppelganger/doppelganger.test.ts#L24

https://github.com/ChainSafe/lodestar/blob/0b43ef7968a82c1e27034a844e353bba9b944f09/packages/beacon-node/test/e2e/eth1/eth1ForBlockProduction.test.ts#L30

https://github.com/ChainSafe/lodestar/blob/0b43ef7968a82c1e27034a844e353bba9b944f09/packages/beacon-node/test/e2e/eth1/eth1MergeBlockTracker.test.ts#L18

https://github.com/ChainSafe/lodestar/blob/0b43ef7968a82c1e27034a844e353bba9b944f09/packages/beacon-node/test/e2e/eth1/eth1Provider.test.ts#L11

https://github.com/ChainSafe/lodestar/blob/0b43ef7968a82c1e27034a844e353bba9b944f09/packages/beacon-node/test/e2e/eth1/stream.test.ts#L9

https://github.com/ChainSafe/lodestar/blob/0b43ef7968a82c1e27034a844e353bba9b944f09/packages/beacon-node/test/e2e/network/mdns.test.ts#L28

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

unstable

wemeetagain commented 3 weeks ago

A lot of these tests would benefit from the ability / infrastructure to generate valid test chains, eg: a chain of valid blocks and states with different properties to import into a BeaconChain. Then we can test against real data.